Itemnotify loot... problem

A forum for reporting bugs NOT related to custom plugins.

Moderator: MacroQuest Developers

JalapenoCrunch
decaying skeleton
decaying skeleton
Posts: 7
Joined: Fri Apr 24, 2009 12:30 am

Itemnotify loot... problem

Post by JalapenoCrunch » Tue Oct 26, 2010 10:10 pm

/varset LootTotal ${Corpse.Items}
/echo ${LootTotal} items on the corpse
/for LootSlot 1 to ${LootTotal}
.
. ${Corpse.Item[${LootSlot}].Name} and ${Corpse.Item[${LootSlot}].NoDrop}
. work fine to choose ${ClickIt}=rightmouseup or leftmouseup
.
/nomodkey /shift /itemnotify loot${LootSlot} ${ClickIt}
.
.
.

The above snippit results in white text error message in the MQ2 chat window from every /itemnotify. The message varies based on lootslot and clickit.

SLOT IS NULL: Could not send notification to loot2 rightmouseup

Echo before the /itemnotify shows that ${LootSlot} ${ClickIt} have the correct contents.
Is it still broken or do I have something else wrong?

I can also manually type the /itemnotify line into the MQ2 window, with a corpse open, and get the same white text. This was happening with the 10/23 code also.

devestator
a ghoul
a ghoul
Posts: 121
Joined: Thu Feb 27, 2003 4:25 pm

Re: Itemnotify loot... problem

Post by devestator » Tue Oct 26, 2010 11:36 pm

Use /itemnotify ${Corpse.Item[${LootSlot}].InvSlot} leftmouseup

With the inventory changes lootN no longer works in reference to inventory slots.

JalapenoCrunch
decaying skeleton
decaying skeleton
Posts: 7
Joined: Fri Apr 24, 2009 12:30 am

Re: Itemnotify loot... problem

Post by JalapenoCrunch » Wed Oct 27, 2010 9:56 pm

Thank you, that fixed it. I have 2 more questions.

Functional changes such as this are inevitable as time goes by but is there a place to check for such changes? I couldn't find anything about the named loot slots not working with itemnotify on the board or wiki.

Also, I know the InvSlot TLO is gone but is there any word on if/when the InvSlot data type will be fixed? FindItem[].InvSlot.Pack and the ability to search thru closed packs were really useful.

In the mean time, keep up the good work. ;)

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Re: Itemnotify loot... problem

Post by dont_know_at_all » Wed Oct 27, 2010 10:31 pm

You can search through closed packs.

Eventually, the wiki will catch up.

JalapenoCrunch
decaying skeleton
decaying skeleton
Posts: 7
Joined: Fri Apr 24, 2009 12:30 am

Re: Itemnotify loot... problem

Post by JalapenoCrunch » Wed Oct 27, 2010 11:28 pm

Is the InvSlot data type (FindItem[xxx].InvSlot.ID, FindItem[xxx].InvSlot.Pack, etc) the same as the TLO InvSlot. Has it been removed also? If it is supposed to still be functional I am getting some inconsistant results.

To demonstrate, put a stack of Opals (or whatever item) in each of 2 backpacks in pack slots 2 and 3. No other Opals in inventory on the toon. Create a one line macro:
/echo "${FindItem[Opal].InvSlot.ID}" "${FindItem[Opal].InvSlot.Pack}"

With both packs open I get: [MQ2] "337" "30"
Pack 2 open pack 3 closed: [MQ2] "337" "30"
Pack 2 closed pack 3 open: [MQ2] "NULL" "NULL"
With both packs closed: [MQ2] "NULL" "NULL"

Move the pack in slot 3 to slot 1 and you get similar results but now FindItem returns NULL unless pack 1 is open. It seems that the pack in the lowest slot containing an item must be open.

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Re: Itemnotify loot... problem

Post by dont_know_at_all » Wed Oct 27, 2010 11:43 pm

Open everything always.

Don't look in the burrito.

JalapenoCrunch
decaying skeleton
decaying skeleton
Posts: 7
Joined: Fri Apr 24, 2009 12:30 am

Re: Itemnotify loot... problem

Post by JalapenoCrunch » Thu Oct 28, 2010 12:12 am

That answer seems contradictory to your previous post or I am misunderstanding something. Can FindItem search through closed packs or do I have to have all packs open?

I can't help but look in the burrito, I usually have to add green chili sauce.

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Re: Itemnotify loot... problem

Post by dont_know_at_all » Thu Oct 28, 2010 3:34 am

You can't click inside closed bags.

FindItem works in closed bags.

drzoon
a hill giant
a hill giant
Posts: 239
Joined: Tue May 04, 2004 5:38 pm

Re: Itemnotify loot... problem

Post by drzoon » Thu Oct 28, 2010 5:22 am

How I understand it is this: The invslot DataType does not work as it did before the HoT expansion and the change to larger bags. Due to the fact that bags can have anything up to 20 slots, the EQ client now only provides the slot information when the bags are open.

Any TLO or other DataType that references invslot (eg. ${InvSlot}, ${FindItem[x].InvSlot}) will now return NULL if the item is in a bag and the bag is closed. If the item is not in a bag (ie. in one of the main worn or pack inventory slots), or is in a bag but the bag is open, it will return the correct value.

JalapenoCrunch
decaying skeleton
decaying skeleton
Posts: 7
Joined: Fri Apr 24, 2009 12:30 am

Re: Itemnotify loot... problem

Post by JalapenoCrunch » Sun Oct 31, 2010 12:29 am

Thanks for the info on .InvSlot. Its reliability is much degraded. FindItem finds and returns an Item object for items in closed bags. Is there a way or can a way be added to determine which bag holds an item if the bag is closed?

devestator
a ghoul
a ghoul
Posts: 121
Joined: Thu Feb 27, 2003 4:25 pm

Re: Itemnotify loot... problem

Post by devestator » Sun Oct 31, 2010 12:47 am

JalapenoCrunch wrote:Thanks for the info on .InvSlot. Its reliability is much degraded. FindItem finds and returns an Item object for items in closed bags. Is there a way or can a way be added to determine which bag holds an item if the bag is closed?
el_nene posted a TLO that could find the bag an item is in the other day, I didn't test it but it looks like it would work:
viewtopic.php?f=46&t=17031

You can also now use my MQ2BagWindow plugin to eliminate the need of opening bags:
viewtopic.php?f=50&t=17035

ivan_the_iv
a lesser mummy
a lesser mummy
Posts: 45
Joined: Sat Jul 03, 2010 9:58 am

Re: Itemnotify loot... problem

Post by ivan_the_iv » Tue Nov 16, 2010 12:29 pm

what folder was this correction made in? I can't seem to find it. Thanks