Why does this crash? ...still crashing...

[Amadeus]

Hmmm...this is rather "out of context"..but, why would it crash EQ?

Code: Select all

			CHAR ZoneName[] = {0};
			sprintf( ZoneName, "%s", CharLower(Zone.ZoneNameShort));

			
			static const char* zoneNames[] = 
			{
				#include "zones.h"   //taken from ShowEQ source
			};

			for (int i = 0; i < (sizeof(zoneNames) / sizeof (char*)); i++) {
				
				if (ZoneName == zoneNames[i]) {
					zoneID = i;
				}
			}

I have put in debugging lines that post to the log file that CONFIRMS that at one point in the for loop, it is checking 'butcher' against 'butcher'; however, it just skips over it (as if the 'if' statement doesn't exist) ..and the whole thing crashes.

I have also used various other things in place of ZoneName == zoneNames (ie, stricmp())....all seem to crash EQ.

[Lax]

Code: Select all

         CHAR ZoneName[] = {0}; 

this makes an array of size 1, with the only element set to null. You want one the size of strlen(Zone.ZoneNameShort) which is guaranteed larger than 1. You can make it a char[128] or something and it will stop crashes.. and just take out the part about setting 0 because its going to get scrapped by the sprintf.

You should also use strcmp or stricmp, because directly comparing ZoneName with ZoneNames is not going to have your intended result

[Amadeus]

Ok ...modified the code. Still crashes EQ very hard when I try this routine.

Code: Select all

			CHAR ZoneName[MAX_STRING];
			sprintf( ZoneName, "%s", CharLower(Zone.ZoneNameShort));
		
			static const char* zoneNames[] = 
			{
				#include "zones.h"   //taken from ShowEQ source
			};

			for (int i = 0; i < (sizeof(zoneNames) / sizeof (char*)); i++) {
				
				if (!stricmp(ZoneName, zoneNames[i] ) ) {
					zoneID = i;
				}
			}

[dont_know_at_all]

stricmp cannot take NULL as an input:

Code: Select all

if (zoneNames[i] && !stricmp(ZoneName, zoneNames[i] ) ) {
    zoneID = i;
}

[lifewolf]

stricmp cannot take NULL as an input:

Code: Select all

if (zoneNames[i] && !stricmp(ZoneName, zoneNames[i] ) ) {
    zoneID = i;
}

Code: Select all

if (zoneNames[i] && !stricmp(ZoneName, zoneNames[i] ) ) {
    zoneID = i;
    break;
}

(you want to break the for loop after you find you zone id, otherwise if its the 4th one your going to be comparing around a hundred more senselessly)