Request [Request Fulfilled]

Macro requests from before the user variable changes that broke all macros

Moderator: MacroQuest Developers

KneightSKye

Request [Request Fulfilled]

Post by KneightSKye » Sun Jul 07, 2002 2:56 am

8)
is there script for a check to make sure inventory is open and if not will open it before continuing in a loop?

i haven't really been able to read and understand some of the more complex scripting and tried to work it in with the simple commands. didn't work to well

GD
a snow griffon
a snow griffon
Posts: 353
Joined: Sat Jun 29, 2002 11:57 pm

Here you go

Post by GD » Sun Jul 07, 2002 7:56 am

A simple, yet effective way to make sure the Inventory is open.

Code: Select all

Sub Main
	/echo Targeting Self
	/press F1
	/echo Clearing Target and opening the Inventory
	/cleanup

	:Loop
		/doevents
		/echo Looping till Target is clear and the Inventory is open
 		/if "$target()"=="TRUE" /goto :Loop
		/echo Target clear, Inventory Open, and Loop Complete
/return

KneightSkye

Thanks ;-)

Post by KneightSkye » Sun Jul 07, 2002 12:29 pm

Thx :D

KneightSkye

=/

Post by KneightSkye » Sun Jul 07, 2002 12:46 pm

it didn't open the inventory... it just looped targeting me and going back to beginning of the macro.

KneightSkye

ok...

Post by KneightSkye » Sun Jul 07, 2002 12:49 pm

did some rearranging of my code and it works now. thanks again man ;-)

KneightSkye

ok i been up all night

Post by KneightSkye » Sun Jul 07, 2002 12:53 pm

errrr ok it doesn't work it was some of my other code that opened the inventory. /sigh sorry.

GD
a snow griffon
a snow griffon
Posts: 353
Joined: Sat Jun 29, 2002 11:57 pm

Post by GD » Sun Jul 07, 2002 12:59 pm

The /cleanup command tells it to hit esc 5 times, then press I to open the inventory

IF it's not working, try adding a delay after the command to give it time for lag, etc.

KneightSkye

my code

Post by KneightSkye » Sun Jul 07, 2002 1:01 pm

this is the code i wrote for this quest that starts out by giving you a stackable sellable item. with this code it's possible to make 360pp an hour.
this code only fills up one bag. i have another that does all 8. if anyone is up to simplifying this code with the more complex scripts then go right ahead. (this code works except a few minor bugs where the inventory won't open and it only works in conjunction with the quest guy and the merchant in his room)
Code wrote:
| --EQ Xploitbag.mac--
| --Scripted By:KneightSkye

Sub Main
/filter name add Filian
/filter name add You Say, 'What Delivery?'
/filter name add Balhallia
/filter food off
/filter money off
/cleanup
/call Bag



Sub Bag
/target Filian
/face
/mouseto inv 0
/click right
/mouseto pack 0 0
/call Quest
/mouseto pack 0 1
/call Quest
/mouseto pack 0 2
/call Quest
/mouseto pack 0 3
/call Quest
/mouseto pack 0 4
/call Quest
/mouseto pack 0 5
/call Quest
/mouseto pack 0 6
/call Quest
/mouseto pack 0 7
/call Quest
/cleanup
/call GoToMerc
/return

Sub Quest
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/say What Delivery?
/delay 18
/click left
/return


Sub GoToMerc
/target Balhallia
:GotoTargLoop
/face
/if "$p1"=="u" /Press u
/call AutoRun 1
/if n $target(distance)>20 /goto :GotoTargLoop
/call AutoRun 0
/mouseto 525 400
/click right
/delay 18
/call SellItem
/return

Sub GoToLoc
:GotoLocLoop
/face loc -74.35,-642.51
/if "$p1"=="u" /Press u
/call AutoRun 1
/if n $distance($p0)>20 /goto :GotoLocLoop
/call AutoRun 0
/delay 10
/cleanup
/call Bag
/return

Sub AutoRun
/if $p0==$v80 /return
/varset v80 $p0
/if $p0==1 /sendkey down up
/if $p0==0 /sendkey up up
/return

Sub SellItem
/sendkey down shift
:SellItem
/finditem similar Bag
/if $find()==FALSE /goto :DoneSellItem
/click left merchant sell
/delay 18
/goto :SellItem
/goto :SellItem
:DoneSellItem
/sendkey up shift
/delay 20
/cleanup
/call GoToLoc
/return

KneightSkye

ok i will try that.

Post by KneightSkye » Sun Jul 07, 2002 1:03 pm

i will try that in a few minutes if the couple extra cleanup's i threw into the code doesn't work.

Guest

Post by Guest » Sun Jul 07, 2002 2:50 pm

can you auto loop sub quest and the sub bag with an incremeting counting variable that may speed things up not sure but would make the code much shorter especially if you add more bags into the code.

User avatar
Madman
a ghoul
a ghoul
Posts: 144
Joined: Wed Jun 26, 2002 4:16 pm

Post by Madman » Sun Jul 07, 2002 2:51 pm

just realised i was not logged in anyways here was what i just posted as a guest


can you auto loop sub quest and the sub bag with an incremeting counting variable that may speed things up not sure but would make the code much shorter especially if you add more bags into the code.

User avatar
L124RD
Site Admin
Site Admin
Posts: 1343
Joined: Fri Jun 14, 2002 12:15 am
Location: Cyberspace
Contact:

Post by L124RD » Sun Jul 07, 2002 10:55 pm

Salutations,
don't know about speed, but that will make it a smaller macro... use /for

User avatar
Madman
a ghoul
a ghoul
Posts: 144
Joined: Wed Jun 26, 2002 4:16 pm

Post by Madman » Sun Jul 07, 2002 11:39 pm

id like to take a look at the one for 8 bags also are they 8 ten slot or 8 slot bags. i have a friend that is gonna see if they can figure out how to add in incrimental loops to see which will be faster to run.

GD
a snow griffon
a snow griffon
Posts: 353
Joined: Sat Jun 29, 2002 11:57 pm

Post by GD » Mon Jul 08, 2002 6:08 am

Well, I haven't tested this yet, but it *should* work, hehe.

Code: Select all

| --EQ Xploitbag.mac--
| --Original by KneightSkye
| --Modified by GD
#include routines.mac

Sub Main
	/filter name add Filian
	/filter name add You Say, 'What Delivery?'
	/filter name add Balhallia
	/filter food off
	/filter money off
	/varset v1 $calc($freeinv(space)-1)

	:Begin
		/cleanup
		/target Filian
		/face
		/for v2 0 to $calc($v1*20)
			/call Quest
		/next v2

	/cleanup
	/call GoToTarg Balhallia
	/call SellItem "Bag of Rations"
	/call GoToTarg Filian
	/goto :Begin


/return

Sub Quest
	/say What Delivery?

	:WaitForBag
		/delay $rand(10)
		/if "$cursor(name)"!="Bag of Rations" /goto :WaitForBag
		/click left auto

	:AutoDropBag
		/if "$cursor(name)"=="Bag of Rations" /goto :AutoDropBag

/return

User avatar
L124RD
Site Admin
Site Admin
Posts: 1343
Joined: Fri Jun 14, 2002 12:15 am
Location: Cyberspace
Contact:

Post by L124RD » Mon Jul 08, 2002 2:55 pm

Salutations,
/clap
much simpler!