TRADESKILL MACROS MOVED NEW THREAD

Post your completed (working) macros here. Only for macros using MQ2Data syntax!

Moderator: MacroQuest Developers

Goofmester1
a hill giant
a hill giant
Posts: 241
Joined: Thu Nov 06, 2003 4:26 am

Post by Goofmester1 » Mon Jan 02, 2006 2:11 am

hawk810 wrote:The pottery mac crashes because of this, although i do not know enough to fix it.

Code: Select all

| ****************** Locs ****************************
   :CounterLooplo
   /if [color=red](${String[${Ini[${FileName},${SectionName},Loc${nValues}]}].Equal[null]})[/color] {
      /varcalc nValues ${nValues}-1
      /goto :MakeArraylo
   }
   /varcalc nValues ${nValues}+1
   /goto :CounterLooplo 
Change this to

Code: Select all

| ****************** Locs ****************************
   :CounterLooplo
  [color=blue] /if (${Ini[${FileName},${SectionName},Loc${nValues}]}.Equal[null]}) {[/color]
      /varcalc nValues ${nValues}-1
      /goto :MakeArraylo
   }
   /varcalc nValues ${nValues}+1 

sanedecline
decaying skeleton
decaying skeleton
Posts: 3
Joined: Fri Mar 04, 2005 7:42 pm

Post by sanedecline » Wed Jan 04, 2006 6:08 am

Used the JC one and ran into a problem when salvge kicked in, when it tried to clean bag it had NULL for bag name. Guessing because when bag is first defined/used, its in a sub and its not kept when sub ends, so when Event is checked it dosnt have the name. I'm Not good enough to fix it properly so that it keeps checking for bag from INI, so I went with the simple fix of changing "${Container}" to "Jeweler's Kit" to get it working for me. Good luck on fixing it =)

Goofmester1
a hill giant
a hill giant
Posts: 241
Joined: Thu Nov 06, 2003 4:26 am

Post by Goofmester1 » Wed Jan 04, 2006 6:21 am

Updated the JC.Mac to goto 276 skill.

jc.mac

Code: Select all

| 

    /varset SkillMaxWanted [color=red]276[/color]
    /varset MerchantName "Rilwind Sitnai" 
    /varset DelayMult 1 

[color=blue]ADD

    /if (${Me.Skill[Jewelry Making]}>=250 && ${Me.Skill[Jewelry Making]}<=276) { 
      /varset BarItem "platinum bar" 
      /varset GemItem "sapphire" 
      /varset CombItemName "PS" 
      /varset ItemTo "Sapphire Platinum Necklace" 
    }
[/color]
    /if (${Me.Skill[Jewelry Making]}>=220 && ${Me.Skill[Jewelry Making]}<250) { 
      /varset BarItem "platinum bar" 
      /varset GemItem "jade" 
      /varset CombItemName "PJ" 
      /varset ItemTo "Jaded Platinum Ring" 
    } 
and to jc.ini add

Code: Select all

[PS] 
Cont=Jeweler's Kit 
Comp0=platinum bar 
Comp1=sapphire
Last edited by Goofmester1 on Wed Jan 04, 2006 9:22 am, edited 1 time in total.

sanedecline
decaying skeleton
decaying skeleton
Posts: 3
Joined: Fri Mar 04, 2005 7:42 pm

Post by sanedecline » Wed Jan 04, 2006 9:09 am

Thats cool, Goofmester1, Ive just finished up to 250 so Ill give it a run. Thanks. (Edit: Seems to be one small problem, Jaded Platinum Ring needs to be set to <250 or it just keeps doing that =)

On a slightly different note, Jaded Platinum Ring recipie was causing me and odd problem, it wouldnt buy the jade. Dunno why, bought everything else fine, I tried throwing delays into buy.inc where the prob seems to be but while it went through it very slow, it still didnt buy the jade, goes on as if it did. If I just buy it myself at that point, works fine. Really odd.

Goofmester1
a hill giant
a hill giant
Posts: 241
Joined: Thu Nov 06, 2003 4:26 am

Post by Goofmester1 » Wed Jan 04, 2006 9:23 am

Made a small correction to what I posted earlier.. forgot to remove the = on the 250 line so would just keep making the jade Ring.

Goofmester1
a hill giant
a hill giant
Posts: 241
Joined: Thu Nov 06, 2003 4:26 am

Post by Goofmester1 » Wed Jan 04, 2006 9:56 am

Found a slightly more cost effective recipe. Saves about 200pp per buy run. Only goes to 274 skill though.

Updated the JC.Mac to goto 274 skill.

jc.mac

Code: Select all

| 

    /varset SkillMaxWanted [color=red]274[/color]
    /varset MerchantName "Rilwind Sitnai" 
    /varset DelayMult 1 

[color=blue]ADD

    /if (${Me.Skill[Jewelry Making]}>=250 && ${Me.Skill[Jewelry Making]}<=274) { 
      /varset BarItem "platinum bar"
      /varset GemItem "fire emerald"
      /varset CombItemName "PS"
      /varset ItemTo "Fire Emerald Platinum Ring"" 
    }
[/color]
    /if (${Me.Skill[Jewelry Making]}>=220 && ${Me.Skill[Jewelry Making]}<250) { 
      /varset BarItem "platinum bar" 
      /varset GemItem "jade" 
      /varset CombItemName "PJ" 
      /varset ItemTo "Jaded Platinum Ring" 
    } 
and to jc.ini add

Code: Select all

[PS] 
Cont=Jeweler's Kit 
Comp0=platinum bar 
Comp1=fire emerald
[/quote]

sanedecline
decaying skeleton
decaying skeleton
Posts: 3
Joined: Fri Mar 04, 2005 7:42 pm

Post by sanedecline » Wed Jan 04, 2006 10:17 am

Thanks Goofmester1, Ive personally set it up to use both of your recipies, so I can get to 276 =) Its working well sofar. With the exception of that jade problem I got, dunno whats with that.

cbsro
decaying skeleton
decaying skeleton
Posts: 1
Joined: Thu Jan 05, 2006 3:04 pm

Post by cbsro » Thu Jan 05, 2006 3:07 pm

Does opening an enviro container work without issues the way you do it here, army? I've done pretty much the same thing in a macro I am working on, but /click left item seems to be dependent on where the cursor is actually positioned for me, or that's the only way I can guess why it works sometimes and doesn't others at the exact same location.

xander
a lesser mummy
a lesser mummy
Posts: 33
Joined: Thu Apr 22, 2004 11:40 pm

pottery.mac problems

Post by xander » Sat Jan 07, 2006 12:10 am

Goofmester1 wrote:
hawk810 wrote:The pottery mac crashes because of this, although i do not know enough to fix it.

Code: Select all

| ****************** Locs ****************************
   :CounterLooplo
   /if [color=red](${String[${Ini[${FileName},${SectionName},Loc${nValues}]}].Equal[null]})[/color] {
      /varcalc nValues ${nValues}-1
      /goto :MakeArraylo
   }
   /varcalc nValues ${nValues}+1
   /goto :CounterLooplo 
Change this to

Code: Select all

| ****************** Locs ****************************
   :CounterLooplo
  [color=blue] /if (${Ini[${FileName},${SectionName},Loc${nValues}]}.Equal[null]}) {[/color]
      /varcalc nValues ${nValues}-1
      /goto :MakeArraylo
   }
   /varcalc nValues ${nValues}+1 
Actually, that didn't work for me. Shouldn't it be this?

Code: Select all

/if (${Ini[${FileName},${SectionName},Loc${nValues}].Equal[null]}) {
But then for me it goes into an endless loop trying to build the loc array...
Xander

hawk810
orc pawn
orc pawn
Posts: 11
Joined: Sat Nov 05, 2005 6:30 pm

Post by hawk810 » Sat Jan 07, 2006 1:40 am

thats the same problem that I had..

Goofmester1
a hill giant
a hill giant
Posts: 241
Joined: Thu Nov 06, 2003 4:26 am

Post by Goofmester1 » Sat Jan 07, 2006 3:52 am

Haven't actually ran the pottery mac since string was removed so can't test it.

But I see I made a mistake posting it earlier and there is one too many } in it.. try this.

Code: Select all

| ****************** Locs ****************************
   :CounterLooplo
   /if (${Ini[${FileName},${SectionName},Loc${nValues}].Equal[null]}) {
      /varcalc nValues ${nValues}-1
      /goto :MakeArraylo
   }
   /varcalc nValues ${nValues}+1
   /goto :CounterLooplo

Trojan
a lesser mummy
a lesser mummy
Posts: 59
Joined: Thu Dec 02, 2004 9:32 am

Post by Trojan » Mon Jan 09, 2006 1:08 pm

Gets rid of the "Misuse of ..." error...but now it just hangs when the macro starts saying

Code: Select all

 'Attempting to read section Abysmal Sea Zone Information from pottery.ini....

armysoldier
a hill giant
a hill giant
Posts: 189
Joined: Mon Jun 27, 2005 2:13 am
Location: Florida (Stationed at FT Carson CO)

Post by armysoldier » Sat Jan 14, 2006 6:41 pm

although using those same macros i never had any string errors.. or reading ini errors..

I have made the changes and added the next lvl to JC mac



THERE are a bunch more TS macros in the VIP macro forum

PLEASE join us there

ARMY

armysoldier
a hill giant
a hill giant
Posts: 189
Joined: Mon Jun 27, 2005 2:13 am
Location: Florida (Stationed at FT Carson CO)

Post by armysoldier » Sun Jan 15, 2006 1:14 am

there is a error message.. variable already in use..

when the macro cycles and reads ini file again

when i post my next macros i will repost these. with the fix...

i just need to move the declare statement to the beginning

it doesn't hurt anything.. just doesn't look professional ..

just wanted you to know

ALSO cleanpacks had an extra thingy and what-cha-ma-callit.. fixed

8-)

ARMY

Esamad
decaying skeleton
decaying skeleton
Posts: 5
Joined: Fri Apr 15, 2005 9:14 am

Post by Esamad » Sun Jan 22, 2006 8:44 am

brewing mac fail at buy items

Code: Select all

Could not send notification to merchant10 leftmouseup
but its problem of the buy.inc