Search found 8 matches

by teabag
Sun May 21, 2006 12:02 am
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

Nor is it expected imo. Let you focus on what you do best. This however is why I made this post. To clarity what is right for those that may not know. Your the best person to answer such questions; not many others are in a position to. I've spent 3 weeks doing Code review so I could do just what you...
by teabag
Sat May 20, 2006 11:31 pm
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

I'm not arguing, I'm trying to clarify a topic since the majority of Plugins in VIP and public are doing exactly what Lax said is wrong. :)
by teabag
Sat May 20, 2006 10:56 pm
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

-- It will return FALSE if GetMember returns FALSE. Changing Unfortunately its not in this case - that was my first question; and problem. If you change the context without returning TRUE, you are setting up a crash. oh? That wouldn't seem to make sense to me, but i'll look into it on my own time. ...
by teabag
Sat May 20, 2006 10:17 pm
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

We can call VarPtr.Ptr->GetName() when it has not been specified? Absolutely not. I know, that was my cynical point :). If I'm reading the code right, the only way you can set Ret.DWord=1 is if your SURE that ParseMacroDataPortion() will return FALSE. If it returns TRUE, the right side of the || wi...
by teabag
Sat May 20, 2006 9:43 pm
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

Quote: This combination ; where pStructureType is NOT of type DWord; is very common amongst Plugins at this time. That's perfectly acceptable, and it's done in MQ2 itself. Sometimes you only have one of any given type of object, such as math, macroquest, and so on, so it's not important to give the ...
by teabag
Sat May 20, 2006 8:44 pm
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

I appreciate the informative response. While this is already what I expected; I was overanalysing it and losing track. Uhhhh... whoever is doing that should be shot, and they should fix their code. You might be suprised by how many plugins are currently doing this. After exploring the source, I expe...
by teabag
Sat May 20, 2006 4:43 pm
Forum: MQ2::Bug Reports
Topic: ParseMQ2DataPortion() Usage and Issues
Replies: 14
Views: 5520

ParseMQ2DataPortion() Usage and Issues

I've been trying to keep the updated MQ2BuffQueue Plugin standardized to MQ2. I've noticed some code bouncing around plugins setting "NULL" by hand and returning true (in the event of TypeMembers not found and the like). However MQ2 also has support for this within ParseMacroData(). Gettin...
by teabag
Fri May 05, 2006 10:36 pm
Forum: MQ2::Bug Reports
Topic: Includes missing from project (vc6)
Replies: 0
Views: 1168

Includes missing from project (vc6)

A rather minor issue; but for the sake of accuracy:

mq2main:
mq2inlines.h
mq2toplevelobjects.h
mq2commands.h

mq2telnet:
telnet.h
wintelnet.h
telnetserver.h